Pullrequest: Change to visibility default setting of review list

1. When review thread is empty : hide 2. When review thread exist : shown
naver · Apr 7, 2015 · e7df11d · e7df11d
1 parent e4acd2e
commit e7df11d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 10 deletions.
diff --git a/app/views/git/viewChanges.scala.html b/app/views/git/viewChanges.scala.html
@@ -47,11 +47,12 @@
                 </div>
             </div>
 
-            <div class="codediff-wrap mt10 @if(requestHeader.cookies.get("diffs-only") != null){diffs-only}">
-                <button type="button" class="ybtn ybtn-default btn-show-reviewcards">
+            <div class="codediff-wrap mt10 @if(pull.commentThreads.size == 0) {diffs-only}">
+              @if(pull.commentThreads.size > 0) {
+              <button type="button" class="ybtn ybtn-default btn-show-reviewcards">
                     <i class="yobicon-restore"></i>
                 </button>
-
+                }
                 <div id="changes" class="diffs-wrap">
                     <div id="commits" class="btn-group auto mb10">
                         <button class="btn dropdown-toggle auto" data-toggle="dropdown">
@@ -150,7 +151,7 @@
                     }
                     @** // BlockComment **@
                 </div>
-
+                @if(pull.commentThreads.size > 0) {
                 <div class="review-wrap">
                     <div class="review-container">
                         <button type="button" class="ybtn ybtn-default btn-hide-reviewcards">
@@ -171,8 +172,10 @@
                                 @partial_reviewlist(pull.getCommentThreadsByState(CommentThread.ThreadState.CLOSED))
                             </div>
                         </div>
+
                     </div>
                 </div>
+                }
             </div>
         </div>
     </div>

diff --git a/public/javascripts/service/yobi.code.Diff.js b/public/javascripts/service/yobi.code.Diff.js
@@ -111,12 +111,6 @@
             htElement.waBtnToggleReviewWrap.on("click", function(){
                 htElement.welContainer.toggleClass("diffs-only");
 
-                if (htElement.welContainer.hasClass("diffs-only")) {
-                    $.cookie("diffs-only", true, {"expire": 365});
-                } else {
-                    $.removeCookie("diffs-only");
-                }
-
                 var positionTop =  10;
                 if(htElement.welReviewContainer.offset().top - positionTop < $(document).scrollTop()){
                     htElement.welReviewContainer