AutoLinkRenderer: Bug fix

Problem: trying to making a link to a commit of the project that is not using code feature. Solution: changed to return empty link for a project that is not using code feature.
naver · Mar 3, 2015 · 923dc51 · 923dc51
1 parent 54f4493
commit 923dc51
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/app/models/Project.java b/app/models/Project.java
@@ -571,6 +571,10 @@ public void changeVCS() throws Exception {
         this.update();
     }
 
+    public boolean isCodeAvailable() {
+        return menuSetting == null || menuSetting.code;
+    }
+
     public enum State {
         PUBLIC, PRIVATE, ALL
     }

diff --git a/app/utils/AutoLinkRenderer.java b/app/utils/AutoLinkRenderer.java
@@ -26,7 +26,9 @@
 import org.apache.commons.lang.ArrayUtils;
 import org.apache.commons.lang.StringUtils;
 import org.jsoup.Jsoup;
-import org.jsoup.nodes.*;
+import org.jsoup.nodes.Document;
+import org.jsoup.nodes.Element;
+import org.jsoup.nodes.TextNode;
 import org.jsoup.select.Elements;
 import org.tmatesoft.svn.core.SVNException;
 import playRepository.Commit;
@@ -276,6 +278,10 @@ private Link toValidSHALink(Project project, String SHA) {
     private Link toValidSHALink(String prefix, Project project, String sha) {
         if (project != null) {
             try {
+                if (!project.isCodeAvailable()) {
+                    return Link.EMPTY_LINK;
+                }
+
                 PlayRepository repository = RepositoryService.getRepository(project);
 
                 if (repository != null) {