Merge branch 'fix/server-error-if-access-unsupported-repo' of dlab/hive

from pull-request 1252 * refs/heads/fix/server-error-if-access-unsupported-repo: git,svn: Respond 404 for unsupported repository Reviewed-by: 김지한 <kim.jihan@navercorp.com> Reviewed-by: 백기선 <keesun.baik@navercorp.com>
naver · Aug 19, 2014 · 696307f · 696307f
2 parents f1bb99c + bb52e67
commit 696307f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/app/controllers/GitApp.java b/app/controllers/GitApp.java
@@ -68,6 +68,10 @@ public static Result service(String ownerName, String projectName, String servic
             return notFound();
         }
 
+        if (!project.vcs.equals(RepositoryService.VCS_GIT)) {
+            return notFound();
+        }
+
         models.User user = UserApp.currentUser();
 
         if (!isAllowed(project, service)) {

diff --git a/app/controllers/SvnApp.java b/app/controllers/SvnApp.java
@@ -111,6 +111,10 @@ public static Result service() throws ServletException, IOException, Interrupted
             return notFound();
         }
 
+        if (!project.vcs.equals(RepositoryService.VCS_SUBVERSION)) {
+            return notFound();
+        }
+
         PlayRepository repository = RepositoryService.getRepository(project);
         if (!AccessControl.isAllowed(currentUser, repository.asResource(),
                 getRequestedOperation(request().method()))) {