Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace MethodNode.parameters usage with Type.getArgumentTypes #140

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Replace MethodNode.parameters usage with Type.getArgumentTypes #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions scavenger-agent-java/src/main/java/com/navercorp/scavenger/javaagent/model/Method.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ private Method(ClassNode classNode, MethodNode methodNode, boolean legacyCompati
private boolean isGetter(MethodNode methodNode) {
Type returnType = Type.getReturnType(methodNode.desc);

return (methodNode.parameters == null || methodNode.parameters.isEmpty())
return Type.getArgumentTypes(methodNode.desc).length == 0
&& returnType != Type.VOID_TYPE && (methodNode.name.startsWith("get")
|| (methodNode.name.startsWith("is") && returnType == Type.BOOLEAN_TYPE)
|| (methodNode.name.matches("component\\d+")) // kotlin component
Expand All @@ -75,8 +75,7 @@ private boolean isGetter(MethodNode methodNode) {

private boolean isSetter(MethodNode methodNode) {
return methodNode.name.startsWith("set")
&& methodNode.parameters != null
&& methodNode.parameters.size() == 1
&& Type.getArgumentTypes(methodNode.desc).length == 1
&& Type.getReturnType(methodNode.desc) == Type.VOID_TYPE;
}

Expand Down
Loading