Skip to content

Commit

Permalink
Remove registerGroup with priority method
Browse files Browse the repository at this point in the history
Signed-off-by: yongjunhong <dev.yongjunh@gmail.com>
  • Loading branch information
YongGoose committed Feb 8, 2025
1 parent 478bb7a commit 8bacdc2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 36 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -418,24 +418,16 @@ public FixtureMonkeyBuilder registerGroup(Class<?>... arbitraryBuilderGroups) {

public FixtureMonkeyBuilder registerGroup(ArbitraryBuilderGroup... arbitraryBuilderGroups) {
for (ArbitraryBuilderGroup arbitraryBuilderGroup : arbitraryBuilderGroups) {
this.registerGroup(arbitraryBuilderGroup, DEFAULT_PRIORITY);
}
return this;
}

public FixtureMonkeyBuilder registerGroup(
ArbitraryBuilderGroup arbitraryBuilderGroup,
int priority
) {
List<ArbitraryBuilderCandidate<?>> candidates = arbitraryBuilderGroup.generateCandidateList()
.getCandidates();

for (ArbitraryBuilderCandidate<?> candidate : candidates) {
this.register(
candidate.getClassType(),
candidate.getArbitraryBuilderRegisterer(),
priority
);
List<ArbitraryBuilderCandidate<?>> candidates = arbitraryBuilderGroup.generateCandidateList()
.getCandidates();

for (ArbitraryBuilderCandidate<?> candidate : candidates) {
this.register(
candidate.getClassType(),
candidate.getArbitraryBuilderRegisterer(),
DEFAULT_PRIORITY
);
}
}
return this;
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -926,24 +926,6 @@ void registerGroupWithPriorityAnnotation() {
then(actual3).isEqualTo(RegisterGroup.FIXED_INT_VALUE);
}

@Property
void registerGroupWithPriority() {
FixtureMonkey sut = FixtureMonkey.builder()
.registerGroup(new SiblingBuilderGroup(), 1)
.registerGroup(new ChildBuilderGroup(), 2)
.build();

String actual = sut.giveMeOne(SimpleObject.class)
.getStr();
List<String> actual2 = sut.giveMeOne(new TypeReference<List<String>>() {
});
ConcreteIntValue actual3 = sut.giveMeOne(ConcreteIntValue.class);

then(actual).hasSizeBetween(4, 6);
then(actual2).hasSizeGreaterThan(3);
then(actual3).isEqualTo(ChildBuilderGroup.FIXED_INT_VALUE);
}

@Property
void registerWithPriorityLessThenZero() {
thenThrownBy(() -> FixtureMonkey.builder()
Expand Down

0 comments on commit 8bacdc2

Please sign in to comment.