fix: fix history state #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qpitlove
approved these changes
Feb 14, 2022
package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "lint": "eslint src", | |||
| "jsdoc": "rm -rf ./doc && jsdoc -c jsdoc.json", | |||
| "coverage": "karma start --coverage", | |||
| "test:node": "node ./dist/persist.js", | |||
There was a problem hiding this comment.
There seems to be confusion because the term test is generally used as a command or prefix to run unit/e2e test.
The purpose is to simply determine whether there is a problem with initialization when the module is executed in node env.
I think names like simulate:node, emulate:node would be more appropriate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#59