Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforceMinMax on stacked guages #3918

Open
Sebastian-medilingua opened this issue Nov 18, 2024 · 3 comments
Open

enforceMinMax on stacked guages #3918

Sebastian-medilingua opened this issue Nov 18, 2024 · 3 comments

Comments

@Sebastian-medilingua
Copy link

Description

I'm trying to create a gauge which shows 3 categories stacked together whilst the max is enforced to a set value. But it doesn't stack then. I can understand why this is, but it makes it hard to figure out why it happens. It feels as if its a bug even though in the code there is clearly a check for it
https://github.com/naver/billboard.js/blob/744c4fdfc0a75b1bb965b2a6d2d861cb6bea6801/src/ChartInternal/shape/arc.ts#L335C3-L344C4

Could it be made more clear that enforceMinMax is currently only for unstacked/multi gauges?
Would it be possible to have it so that data can be stacked and have a limit? (Or is that not possible)

Steps to check or reproduce

https://jsfiddle.net/357rLq90/2/

(what I intended was that received and expected are fully shown and due being only partially shown but the labels displaying the correct value)

@netil
Copy link
Member

netil commented Dec 3, 2024

Hi @Sebastian-medilingua, as you stated enforMinMax option only works for single data value.
It can be an enhancement expand the support for stacked values. I'll go over some chances for future release.

Thanks for the suggestion.

@Sebastian-medilingua
Copy link
Author

Hi @netil, though that would be nice, I think the documentation is still a bit unclear right now and probably should be updated.

image

as you can see other items contain limitations and notes but enforceMinMax doesn't. Could it be updated whilst the enhancement is in consideration?

netil pushed a commit to netil/billboard.js that referenced this issue Dec 4, 2024
Currently enforceMinMax option works for single data series only.
Make sure clarifying the use of this option

Ref naver#3918
netil added a commit that referenced this issue Dec 4, 2024
Currently enforceMinMax option works for single data series only.
Make sure clarifying the use of this option

Ref #3918

Co-authored-by: netil <netil@AD02298065.local>
netil added a commit that referenced this issue Dec 4, 2024
Currently enforceMinMax option works for single data series only.
Make sure clarifying the use of this option

Ref #3918
@netil netil added the doc label Dec 4, 2024
@netil
Copy link
Member

netil commented Dec 4, 2024

Updated the doc clarifying the option works for single data series only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants