Add workflow that scans orphaned PR environments #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coilysiren couple of other changes here:
|
coilysiren
approved these changes
Jan 3, 2025
Comment on lines
3
to
23
| # Configuration for system notifications | ||
| # used by CI/CD workflows to send notifications for deployments, | ||
| # failed workflows, etc. | ||
| system_notifications_config = { | ||
|
|
||
| # channels is a map of notification channels, where each key is a | ||
| # notification channel and each value is the channel configuration. | ||
| # | ||
| # A channel configuration contains contains the following attributes: | ||
| # type: Type of notification channel (e.g. "slack", or "teams"). | ||
| # currently only "slack" is supported | ||
| # | ||
| # If the channel `type` is missing or null, system notifications sent to | ||
| # that channel will result in a no-op. | ||
| # | ||
| # If the channel `type` is "slack", the configuration must also contain the | ||
| # following attributes: | ||
| # channel_id_secret_name: Name of the secret in GitHub that contains the | ||
| # Slack channel ID | ||
| # slack_token_secret_name: Name of the secret in GitHub that contains the | ||
| # Slack bot token |
There was a problem hiding this comment.
This took me a while to parse, but it LGTM
There was a problem hiding this comment.
Took a pass at improving it. Open to additional suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Resolves #709
Changes
Context for reviewers
I also pulled out get_app_names function from infra-deploy-status-check-configs into a utils.bash library file.
Testing
Developed and tested on navapbc/platform-test#143