Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alphabetize makefile #773

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Alphabetize makefile #773

merged 2 commits into from
Oct 30, 2024

Conversation

rylew1
Copy link
Contributor

@rylew1 rylew1 commented Oct 30, 2024 •
edited
Loading

Ticket

Changes

  • Move e2e targets above infra targets
  • Give infra targets a comment block header
  • Give lint target a comment block header

Context

  • We have some nicely namespaced sections so it seemed like we should keep them in order

  • Technically the helper scripts are at the bottom so maybe the phony list should reflect that

@rylew1 rylew1 requested review from lorenyu and removed request for lorenyu October 30, 2024 16:47
@rylew1 rylew1 merged commit 76d1cf8 into main Oct 30, 2024
1 check passed
@rylew1 rylew1 deleted the rylew/makefile-alphabetize branch October 30, 2024 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenyu lorenyu lorenyu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylew1 @lorenyu