ALB deletion protection #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lorenyu
reviewed
Jan 17, 2024
lorenyu
reviewed
Jan 17, 2024
| @@ -7,11 +7,12 @@ BACKEND_CONFIG_FILE="dev.s3.tfbackend" | |||
|
|
|||
| sed -i.bak 's/force_destroy = false/force_destroy = true/g' infra/modules/service/access-logs.tf | |||
| sed -i.bak 's/force_destroy = false/force_destroy = true/g' infra/modules/storage/main.tf | |||
| sed -i.bak 's/enable_deletion_protection = var.is_temp_environment/enable_deletion_protection = false/g' infra/modules/service/load-balancer.tf | |||
There was a problem hiding this comment.
i think you just copy pasted my snippet, but you have to make sure that the line you are replacing is the same as the actual line. looks like you named the variable is_temporary rather than is_temp_environment
lorenyu
approved these changes
Jan 17, 2024
Co-authored-by: Loren Yu <loren@navapbc.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent ALB Deletion for security compliance
Resolves #161
Changes
Use the
terraform.workspacename to determine if this is a test environment and therefore the alb should not get deletion protection, otherwise, enable deletion protection. Terratest prefixes workspaces it createst with "t-<unique_id>" therefore we should enable deletion protection for elbs in all workspaces that do not start witht-Addresses:
ELB.6 check: NIST-800 53