Update E2E packages #94
Conversation
Makefile
Outdated
| playwright-e2e | ||
| playwright-e2e | grep -v "To open last HTML report run" | grep -v "npx playwright show-report" | ||
| @echo "📄 HTML report generated!" | ||
| @echo "🔍 View it with: make e2e-show-report" |
There was a problem hiding this comment.
remove the default playwright command it shows and insert our make command
There was a problem hiding this comment.
Hmm, pretty clever. It's a little too clever/magical for my tastes, and it's also brittle since the playwright CLI output isn't an API we can rely on.
There was a problem hiding this comment.
What about not removing the the playwright command but just echo'ing the make command ?
Will move just the package updates over to template-infra
There was a problem hiding this comment.
@lorenyu see above comment if it makes sense to do
There was a problem hiding this comment.
What about not removing the the playwright command but just echo'ing the make command ?
Sure that sounds good
Makefile
Outdated
| @if [ ! -d "./e2e/blob-report" ]; then \ | ||
| echo "❗The blob-report folder does not exist. Cannot merge reports."; \ | ||
| exit 1; \ | ||
| elif [ -z "$(wildcard ./e2e/blob-report/*)" ]; then \ | ||
| echo "❗The blob-report folder is empty. Cannot merge reports."; \ | ||
| exit 1; \ | ||
| else \ |
There was a problem hiding this comment.
this doesn't feel worth it to me. it makes the code a lot less readable (1 line --> 9 lines of mostly error handling) for what feels like minimal benefit
Makefile
Outdated
| @if [ ! -d "./e2e/playwright-report" ]; then \ | ||
| echo "❗ Error: The playwright-report folder does not exist. Cannot display reports."; \ | ||
| exit 1; \ | ||
| elif [ -z "$(wildcard ./e2e/playwright-report/*)" ]; then \ | ||
| echo "❗ Error: The playwright-report folder is empty. Cannot display reports."; \ | ||
| exit 1; \ | ||
| else \ | ||
| cd e2e && npx playwright show-report; \ | ||
| fi |
There was a problem hiding this comment.
same here, the error handling code makes this a lot harder to read
Makefile
Outdated
| playwright-e2e | ||
| playwright-e2e | grep -v "To open last HTML report run" | grep -v "npx playwright show-report" | ||
| @echo "📄 HTML report generated!" | ||
| @echo "🔍 View it with: make e2e-show-report" |
There was a problem hiding this comment.
Hmm, pretty clever. It's a little too clever/magical for my tastes, and it's also brittle since the playwright CLI output isn't an API we can rely on.
|
Moved to |
Ticket
Resolves navapbc/template-infra#801
Changes
Preview environment for app
Preview environment
♻️ Environment destroyed ♻️