Fixes pynautobot for v1.6.16 auth changes #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvanderaa
approved these changes
Mar 27, 2024
|
Looks good. We should open an issue to make a new release with requiring the token as part of the initialization as well as an enhancement. Not holding this back though. |
I believe the reason why it's not a required argument is because you can also use the environment variable. It is still ultimately "required" though to do almost any function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v1 fix for #172
This PR adds the token to status, version and openapi calls. I also updated our CI to only test nautobot v1.6 as well as added python 3.11.