Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LocationType Specification to DNA Center and Device42 #546

Merged
merged 36 commits into from
Oct 3, 2024

Conversation

jdrew82
Copy link
Contributor

@jdrew82 jdrew82 commented Sep 12, 2024

This PR is to update the DNA Center integration to add the capability to specify the LocationType for each of the types of location objects that are imported. I've also added the missing User documentation along with screenshots for how to use the integration and steps to add the required pieces.

@jdrew82 jdrew82 added type: documentation Issues/PRs addressing documentation. type: major feature integration: dna center Issues/PRs for Cisco DNA Center integration. labels Sep 12, 2024
@jdrew82 jdrew82 self-assigned this Sep 12, 2024
@jdrew82 jdrew82 requested review from qduk, a team and chadell as code owners September 12, 2024 23:31
@Kircheneer
Copy link
Contributor

I see some device42 commits in here, is this intended?

@jdrew82 jdrew82 changed the title Add LocationType Specification to DNA Center Add LocationType Specification to DNA Center and Device42 Sep 16, 2024
@jdrew82
Copy link
Contributor Author

jdrew82 commented Sep 16, 2024

I see some device42 commits in here, is this intended?

Yeah, that's intentional. I figured might as well update any of the integrations that could benefit from the option.

@jdrew82 jdrew82 added the integration: device42 Issues/PRs for Device42 Integration label Sep 16, 2024
@jdrew82 jdrew82 linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link
Contributor

@gsnider2195 gsnider2195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ruff is failing formatting on nautobot_ssot/tests/dna_center/test_adapters_nautobot.py. Otherwise looks good!

@jdrew82 jdrew82 merged commit 3359ed6 into develop Oct 3, 2024
14 checks passed
@jdrew82 jdrew82 deleted the feat-add_loctypes branch October 3, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration: device42 Issues/PRs for Device42 Integration integration: dna center Issues/PRs for Cisco DNA Center integration. type: documentation Issues/PRs addressing documentation. type: major feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Integrations to Allow Specifying LocationTypes
3 participants