-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LocationType Specification to DNA Center and Device42 #546
Conversation
…ne file for easier re-use.
…as, Buildings, and Floors from DNAC.
…Sync models. Also update adapters and models to use the new attributes.
…nals as it is expected users will create these now and specify in Job form.
…support in case Controller is assigned Floor LocationType.
…e LocationType used for imported Buildings. Will resort to Site LocationType to align with previous handling of LocationType for Buildings.
… and Room DiffSync models.
I see some device42 commits in here, is this intended? |
Yeah, that's intentional. I figured might as well update any of the integrations that could benefit from the option. |
…bout bulk actions.
nautobot_ssot/integrations/dna_center/diffsync/adapters/dna_center.py
Outdated
Show resolved
Hide resolved
nautobot_ssot/integrations/dna_center/diffsync/adapters/nautobot.py
Outdated
Show resolved
Hide resolved
nautobot_ssot/integrations/dna_center/diffsync/models/nautobot.py
Outdated
Show resolved
Hide resolved
… Site to be consistent.
…are configured correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ruff is failing formatting on nautobot_ssot/tests/dna_center/test_adapters_nautobot.py
. Otherwise looks good!
This PR is to update the DNA Center integration to add the capability to specify the LocationType for each of the types of location objects that are imported. I've also added the missing User documentation along with screenshots for how to use the integration and steps to add the required pieces.