-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Nautobot 2.0 #142
Conversation
Starting update to support Nautobot 2.0 Now requires Nautobot 2.0 or better.
…nction was removed from core.
…ocationType of Region & Site Also updated to use new register_jobs pattern.
…as no longer needed.
Also discovered issubclass to determine if Job is subclass of DataSource or DataTarget which is better than checking for SSoT in slug that no longer exists.
…s defined based on plugin config.
…levant any longer.
Updated Regions and Sites to use Locations and LocationTypes to match migrations. Same with Prefixs using Namespace for uniqueness instead of Tenant now. Also removed slug and used names for Status, Region, and Site. Logging has been updated to use JobResult object. Dry-run var is now using DryRunVar() for scheduling support. Updated everything to latest locations for Nautobot 2.0 so many many breaking changes.
… associated Job modules loaded.
As part of the changes removed Aggregate objects as that is no longer a valid model in 2.0. Updated all Site creation to be a Location. Also removed the associated setting for importing Aggregates. Updates for Nautobot 2.0 so lots of breaking changes. No longer an Aggregate object to import and removed extraneous Job. The `import_rfc1918" setting is no longer valid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks go for me
…Nautobot 2.0 change.
…etwork status in Infoblox.
…not start until service_healthy.
This should be ready for a re-review for beta 2. I fixed all the issues with Infoblox integration working with 2.0 and confirmed the example Job and the Infoblox import jobs work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it still makes sense to me
Very tiny nitpick, apart from that we're good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is focused on the updates required to support Nautobot 2.0. The changes involved include:
Both example import Job and Infoblox -> Nautobot import Job are functional with test instances.
Addresses #148.