Enable Upstream Testing #56
Conversation
bryanculver
commented
Dec 6, 2022
•
bryanculver
commented
- Updated Dockerfile to be compatible with upstream testing
- Added workflow fragment to trigger testing
- Fixed dependency issues with cryptography vs pyopenssl
- Fixed by using Nautobot version up to 1.5.10
- unittest for 1.5.11 and 1.5.12 fails due to AttributeError: module 'lib' has no attribute 'OpenSSL_add_all_algorithms'. AWS sam build failure. pyca/cryptography#7959 (comment)
- Fixed Docker build poetry dependency error with mkdocs
- Updated minimal Nautobot to v1.4.0
|
|
snaselj
force-pushed
the
bsc-2023-upstream-testing
branch
from
117655f to
5edc348
Compare
|
Rebased on top of |
- Install all dependencies
|
The only test failing now is with upstream testing This PR is ready for review |
snaselj
requested review from
itdependsnetworks,
jathanism and
jedelman8
as code owners
|
I will revert changes to pyopenssl and cryptography version and bump nautobot dependency to 1.4. |
snaselj
force-pushed
the
bsc-2023-upstream-testing
branch
5 times, most recently
from
da9bb85 to
539f7b2
Compare
|
All tests excluding upstream monitoring are now passing. |
- CI pylint using Nautobot 1.4.10 - CI unittest using Nautobot [1.4.10, 1.5.10] to avoid bug in 1.5.11 and 1.5.12
snaselj
force-pushed
the
bsc-2023-upstream-testing
branch
from
6a3e905 to
e1dbaa2
Compare
|
I force pushed last commits to align pylint and unittest CI versions according to the latest template. This PR is ready for review now, all comments are addressed. |
bryanculver
dismissed
glennmatthews’s stale review
Issue with pyopenssl resolved. Other feedback addressed.
|
@nautobot/core Can I get a final once-over? Since I was the one to open the PR I can't review and merge it myself. |
|
|
||
| on: # yamllint disable-line rule:truthy rule:comments | ||
| schedule: | ||
| - cron: "0 4 */2 * *" # every other day at midnight |
There was a problem hiding this comment.
The comment says midnight but the crontab is 4am
There was a problem hiding this comment.
@bryanculver There is wrong comment in the template, didn't notice that yet, will fix it here and in the template.
README.md
Outdated
| Nautobot Secrets Providers is a plugin for [Nautobot](https://github.com/nautobot/nautobot) 1.2.0 or higher that bundles Secrets Providers for integrating with popular secrets backends. Nautobot 1.2.0 added support for integrating with retrieving secrets from various secrets providers. | ||
| Nautobot Secrets Providers is a plugin for [Nautobot](https://github.com/nautobot/nautobot) 1.4.0 or higher that bundles Secrets Providers for integrating with popular secrets backends. Nautobot 1.4.0 added support for integrating with retrieving secrets from various secrets providers. |
There was a problem hiding this comment.
Is this accurate? Pypi goes back to version 1.0.0 which supports nautobot ~1.2.1
There was a problem hiding this comment.
The template we use has minimal Nautobot version v1.4.
There was a problem hiding this comment.
@snaselj @gsnider2195 is suggesting that this message is inaccurate. It's more-so speaking to the historical support of Secrets which was introduced in 1.2. We are moving up the minimum version but that doesn't rewrite history.
| > Nautobot Secrets Providers is compatible with Nautobot 1.2.0 and higher. Support for Thycotic Secret Server requires Python 3.7 or later. | ||
| > Nautobot Secrets Providers is compatible with Nautobot 1.4.0 and higher. Support for Thycotic Secret Server requires Python 3.7 or later. |
There was a problem hiding this comment.
The template we use has minimal Nautobot version v1.4.
There was a problem hiding this comment.
Unlike the above, I think this change is OK because read in the context of the plugin today (if this is merged) it will support 1.4+ but you can find older versions that support older versions of Nautobot.
This is where compatibility matrixes come in handy which is something other apps have started introducing.
