-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation Update #79
Conversation
|
||
| Netbox First Support Version | Netbox Last Support Version | Nautobot NetBox Importer Version | Nautobot First Support Version | Nautobot Last Support Version | | ||
| ---------------------------- | --------------------------- | -------------------------------- | ------------------------------ | ----------------------------- | | ||
| 2.10.3 | 2.10.8 | 1.0.X | 1.0.0b3 | 1.3.7 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implication here is that we don't support any Nautobot version after 1.3.7?? Normally I'd expect the last supported version to be 1.5.99 (i.e. any 1.x version, but not 2.x).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is the goal, but testing Nautobot 1.4.x and 1.5.x is not working (issue open), so I tried to keep it as close to reality as possible (until we solve how to support them)
|
||
## Authors and Maintainers | ||
|
||
@glennmatthews Glenn Matthews |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a team/codeowners alias that we can identify here instead of making me solely responsible? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we use the github team @nautobot/po-tl-data-management
?
poetry.lock
Outdated
{file = "astroid-2.11.6-py3-none-any.whl", hash = "sha256:ba33a82a9a9c06a5ceed98180c5aab16e29c285b828d94696bf32d6015ea82a9"}, | ||
{file = "astroid-2.11.6.tar.gz", hash = "sha256:4f933d0bf5e408b03a6feb5d23793740c27e07340605f236496cd6ce552043d6"}, | ||
] | ||
astroid = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removal of file checksums here and below suggests that you are running an older version of poetry
and/or need to run poetry cache clear pypi --all
, then regenerate the file with poetry lock --no-upgrade
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully fixed, I was using poetry 1.1.13 - updated to 1.3 now.
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chadell a few fixes to resolve build warnings and formatting.
Co-authored-by: Cristian <cmsirbu@users.noreply.github.com>
@chadell @glennmatthews You can't tell from the PR itself, but I retriggered the CI to run and it's actually succeeding now -> https://github.com/nautobot/nautobot-plugin-netbox-importer/actions/runs/3696298530 |
Looks like this repo isn't enabled for ReadTheDocs yet? At least I don't see any RTD steps in the CI results. |
@glennmatthews it's all set up on RTD - they use their own CI with webhooks from here: https://docs.nautobot.com/projects/netbox-importer/en/latest/ It's currently building from this branch, so the landing page is a bit broken until this gets merged to develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What's changed
develop
.invoke docs
task to aid serving docs locally in the dev environment.docs/requirements.txt
are in sync with dependencies inpyproject.toml
.Building docs
You can build the docs locally in the poetry environment:
See below notes on development environment (more specifically the docker based one).
TODO
Some sections throughout the files listed below require input (or removal if not applicable to this plugin). All
Developer Note
comments should be resolved and removed.docs/admin/release_notes
, but will leave this decision up to you.