Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Update #79

Merged
merged 17 commits into from
Dec 15, 2022
Merged

Documentation Update #79

merged 17 commits into from
Dec 15, 2022

Conversation

cmsirbu
Copy link
Contributor

@cmsirbu cmsirbu commented Nov 18, 2022

What's changed

  • Moved existing documentation into a new structure to prepare for the mkdocs rendered docsite.
  • Edited and improved the visuals in various places using new syntax from the Material for Mkdocs theme.
  • Added dependencies to poetry environment for development.
  • Added configuration for building and hosting the docsite on RTD.
  • Replaced the project README with a standardized one. Note: the README will have certain links/images broken until the PR is merged into develop.
  • Added invoke docs task to aid serving docs locally in the dev environment.
  • Added test to check that RTD used docs/requirements.txt are in sync with dependencies in pyproject.toml.

Building docs

You can build the docs locally in the poetry environment:

poetry install
poetry run mkdocs serve

See below notes on development environment (more specifically the docker based one).

TODO

Some sections throughout the files listed below require input (or removal if not applicable to this plugin). All Developer Note comments should be resolved and removed.

  • user/app_overview.md
  • user/app_use_cases.md
  • user/app_getting_started.md
  • user/faq.md
  • user/external_interactions.md
  • admin/install.md - review
  • admin/upgrade.md
  • admin/uninstall.md
  • admin/compatiblity_matrix.md
  • admin/release_notes - I think the CHANGELOG content should be linking to the docs section release notes (and its contents moved into docs/admin/release_notes, but will leave this decision up to you.
  • dev/extending.md - review
  • dev/contributing.md
  • dev/dev_environment.md - boilerplate guide based on cookie template (old GETTING_STARTED guide). A sync to the cookie dev environment would be beneficial to ensure instructions are accurate.
  • dev/code_reference - check examples provided and add any module/package auto-generated docs that are relevant
  • README.md - add description/overview

@chadell chadell self-assigned this Nov 30, 2022
@chadell chadell marked this pull request as ready for review December 5, 2022 17:52
.github/workflows/ci.yml Outdated Show resolved Hide resolved

| Netbox First Support Version | Netbox Last Support Version | Nautobot NetBox Importer Version | Nautobot First Support Version | Nautobot Last Support Version |
| ---------------------------- | --------------------------- | -------------------------------- | ------------------------------ | ----------------------------- |
| 2.10.3 | 2.10.8 | 1.0.X | 1.0.0b3 | 1.3.7 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implication here is that we don't support any Nautobot version after 1.3.7?? Normally I'd expect the last supported version to be 1.5.99 (i.e. any 1.x version, but not 2.x).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is the goal, but testing Nautobot 1.4.x and 1.5.x is not working (issue open), so I tried to keep it as close to reality as possible (until we solve how to support them)

docs/admin/release_notes/version_1.0.md Show resolved Hide resolved
docs/dev/contributing.md Outdated Show resolved Hide resolved
docs/user/app_getting_started.md Outdated Show resolved Hide resolved
docs/user/app_overview.md Outdated Show resolved Hide resolved
docs/user/app_overview.md Outdated Show resolved Hide resolved

## Authors and Maintainers

@glennmatthews Glenn Matthews
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a team/codeowners alias that we can identify here instead of making me solely responsible? :-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we use the github team @nautobot/po-tl-data-management?

docs/user/app_use_cases.md Outdated Show resolved Hide resolved
poetry.lock Outdated
{file = "astroid-2.11.6-py3-none-any.whl", hash = "sha256:ba33a82a9a9c06a5ceed98180c5aab16e29c285b828d94696bf32d6015ea82a9"},
{file = "astroid-2.11.6.tar.gz", hash = "sha256:4f933d0bf5e408b03a6feb5d23793740c27e07340605f236496cd6ce552043d6"},
]
astroid = []
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removal of file checksums here and below suggests that you are running an older version of poetry and/or need to run poetry cache clear pypi --all, then regenerate the file with poetry lock --no-upgrade.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully fixed, I was using poetry 1.1.13 - updated to 1.3 now.

chadell and others added 2 commits December 12, 2022 18:22
Co-authored-by: Glenn Matthews <glenn.matthews@networktocode.com>
Copy link
Contributor Author

@cmsirbu cmsirbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chadell a few fixes to resolve build warnings and formatting.

mkdocs.yml Outdated Show resolved Hide resolved
docs/admin/release_notes/version_1.0.md Outdated Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
@cmsirbu
Copy link
Contributor Author

cmsirbu commented Dec 14, 2022

@chadell @glennmatthews You can't tell from the PR itself, but I retriggered the CI to run and it's actually succeeding now -> https://github.com/nautobot/nautobot-plugin-netbox-importer/actions/runs/3696298530

@glennmatthews
Copy link
Contributor

Looks like this repo isn't enabled for ReadTheDocs yet? At least I don't see any RTD steps in the CI results.

@cmsirbu
Copy link
Contributor Author

cmsirbu commented Dec 14, 2022

@glennmatthews it's all set up on RTD - they use their own CI with webhooks from here: https://docs.nautobot.com/projects/netbox-importer/en/latest/

It's currently building from this branch, so the landing page is a bit broken until this gets merged to develop.

Copy link
Contributor

@chadell chadell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chadell chadell merged commit 044c6ee into develop Dec 15, 2022
@chadell chadell deleted the cmsirbu-docs-reorg branch December 15, 2022 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants