fix test_tags_filter() test #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HanlinMiao
requested review from
itdependsnetworks,
jeffkala and
nkallergis
as code owners
gsnider2195
approved these changes
Aug 6, 2024
| @@ -300,9 +300,17 @@ class Meta: | |||
| class ConfigPlanFilterSet(NautobotFilterSet): | |||
| """Inherits Base Class NautobotFilterSet.""" | |||
|
|
|||
| q = django_filters.CharFilter( | |||
| method="search", | |||
There was a problem hiding this comment.
The method search was undefined? Odd that this didn't raise an exception
There was a problem hiding this comment.
I think it just got overridden by the redundant q filter down below. That is why it did not raise an exception.
gsnider2195
reviewed
Aug 6, 2024
changes/786.fixed
Outdated
| @@ -0,0 +1 @@ | |||
| Fixed incorrect test data setup for `test_tags_filter()` test for `ConfigPlanFilterTestCase`. | |||
There was a problem hiding this comment.
IMO this should be housekeeping
glennmatthews
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.