Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FloorPlan resize validation #137

Merged
merged 5 commits into from
Dec 16, 2024
Merged

FloorPlan resize validation #137

merged 5 commits into from
Dec 16, 2024

Conversation

djhoward12
Copy link
Collaborator

Adding validation to ensure FloorPlan can't be resized if tiles have been placed. Fixing spelling and formatting of documentation

Adding validation to ensure FloorPlan can't be resized if tiles have …
34f1d7b 
…been placed. Fixing spelling and formatting of documentation
@djhoward12 djhoward12 linked an issue Dec 4, 2024 that may be closed by this pull request
Floor plan can be resized to leave racks outside allowable bounds. #132
Closed
joewesch
joewesch reviewed Dec 11, 2024
View reviewed changes
changes/132.fixed Outdated Show resolved Hide resolved
nautobot_floor_plan/tests/test_models.py Show resolved Hide resolved
djhoward12 and others added 2 commits December 11, 2024 11:45
@djhoward12 @joewesch
Update changes/132.fixed
addef37 
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
separating x and y resize tests
48394cb
smk4664
smk4664 requested changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should document this change and why it is being changed, just so it is clear in the documentation if they encounter the error.

@djhoward12
Copy link
Collaborator Author

We should document this change and why it is being changed, just so it is clear in the documentation if they encounter the error.

Updated documentation to address changes to floor plan resize validation.

@djhoward12 djhoward12 requested a review from smk4664 December 16, 2024 15:04
smk4664
smk4664 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@smk4664 smk4664 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes!

@smk4664 smk4664 merged commit c0c8c34 into nautobot:develop Dec 16, 2024
15 checks passed
@djhoward12 djhoward12 deleted the djhoward12-naaps-132-grid-resize-validation branch December 16, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smk4664 smk4664 smk4664 approved these changes

@joewesch joewesch joewesch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Floor plan can be resized to leave racks outside allowable bounds.
3 participants
@djhoward12 @joewesch @smk4664