Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Djhoward12 naaps 124 child tabs #135
Djhoward12 naaps 124 child tabs #135
Changes from 6 commits
be28397
ae91942
b9ac301
6611160
ef5a030
2ea6b47
0879dc5
53fc9fb
554624b
ce69526
0839787
3ab67dc
50522bd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@glennmatthews When we start removing the object templates in favor of the Python template generation, will this be a problem? I am not asking DJ to change this, just curious how future changes in Nautobot would impact this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point, yeah, this will need to change to just being based on
generic/object_retrieve.html
(or adopt the UI Component Framework itself). For now we're keeping and just hollowing out the core templates (rather than deleting them entirely) to avoid exactly this problem in 2.x.