update docs and dependencies #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav-C
requested review from
mzbroch,
scetron,
glennmatthews,
chadell and
housepbass
as code owners
| | Device Type | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :x: | | ||
| | Mgmt Interface | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :x: | | ||
| | Mgmt IP Address | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :white_check_mark: | :x: | | ||
| | Hostname | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ❌ | |
There was a problem hiding this comment.
Can we use the actual unicode/emoji characters ✅ ❌ 🧪 here? For example:
Suggested change
| | Hostname | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ❌ | | |
| | Hostname | ✅ | ✅ | ✅ | ✅ | ✅ | ✅ | ❌ | |
(see also #218).
| @@ -0,0 +1 @@ | |||
| Remove secrets-provider app dependency update doc dependencies | |||
There was a problem hiding this comment.
Suggested change
| Remove secrets-provider app dependency update doc dependencies | |
| Removed secrets-provider app dependency. | |
| Updated documentation dependencies. |
Comment on lines
13
to
+28
| """Verify that pyproject.toml dev dependencies have the same versions as in the docs requirements.txt.""" | ||
| parent_path = os.path.dirname(os.path.dirname(os.path.dirname(os.path.realpath(__file__)))) | ||
| parent_path = os.path.dirname( | ||
| os.path.dirname(os.path.dirname(os.path.realpath(__file__))) | ||
| ) | ||
| poetry_path = os.path.join(parent_path, "pyproject.toml") | ||
| poetry_details = toml.load(poetry_path)["tool"]["poetry"]["group"]["dev"]["dependencies"] | ||
| with open(f"{parent_path}/docs/requirements.txt", "r", encoding="utf-8") as file: | ||
| requirements = [line for line in file.read().splitlines() if (len(line) > 0 and not line.startswith("#"))] | ||
| poetry_details = toml.load(poetry_path)["tool"]["poetry"]["group"]["dev"][ | ||
| "dependencies" | ||
| ] | ||
| with open( | ||
| f"{parent_path}/docs/requirements.txt", "r", encoding="utf-8" | ||
| ) as file: | ||
| requirements = [ | ||
| line | ||
| for line in file.read().splitlines() | ||
| if (len(line) > 0 and not line.startswith("#")) | ||
| ] |
There was a problem hiding this comment.
Is this just a formatting change? Did the poetry.lock updates include updates to ruff, or why was this necessary?
| @@ -66,11 +66,15 @@ def is_truthy(arg): | |||
|
|
|||
|
|
|||
| def _is_compose_included(context, name): | |||
There was a problem hiding this comment.
Are all of the below changes just due to a different version of ruff?
There was a problem hiding this comment.
The scope of this PR is too large and includes things that overlap with drift manager. I will close it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the secrets-providers app as a dependency
Update readme to fix icons
Add/Update docs dependencies to match core
Increase Nautobot version for local development and CI to 2.3.0