Add options to assign secret group and mgmt only interface status #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susanhooks
requested review from
mzbroch,
scetron,
glennmatthews and
chadell
as code owners
scetron
approved these changes
Dec 14, 2023
mzbroch
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
LGTM
Since this is a job now, I'd discuss if we should move settings into Jobs Settings - so that those could be overridden through UI. This previous pattern with every small setting defined in nautobot_config.py is not very user friendly. (cc @whitej6 )
|
@mzbroch I'd agree with that, it'd be really nice to move them from the config. I will open an issue and take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #133 , added the feature to assign the secret group used in onboarding to the device upon creation/update. Additionally added the feature to set the IP used with onboarding as managment only.