Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Config Schema #286

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

App Config Schema #286

wants to merge 1 commit into from

Conversation

snaselj
Copy link
Contributor

@snaselj snaselj commented Feb 28, 2024

Closes Nan

What's Changed

  • Added app config schema.

@snaselj snaselj mentioned this pull request Mar 7, 2024
Merged
@jvanderaa
Copy link
Collaborator

@snaselj what does this do?

@snaselj
Copy link
Contributor Author

snaselj commented May 31, 2024

@snaselj what does this do?

@jvanderaa

Explained here:

https://github.com/nautobot/nautobot-app-circuit-maintenance/blob/develop/docs/dev/dev_environment.md#app-configuration-schema

The plan was to define configuration schema for each app to verify the configuration provided with PLUGINS_CONFIG[<app_name>] or in Nautobot Cloud.

@jvanderaa
Copy link
Collaborator

I still don't understand what it does.

@chadell
Copy link
Contributor

chadell commented Jun 28, 2024

It is used by Nautobot Cloud to generate a form of the available settings

@jvanderaa
Copy link
Collaborator

The documentation says that the app has to configure these settings. At least with what is linked. Do I configure foo = bar()? There isn't anything else linked to say how to know that this is a valid PR.

jvanderaa
jvanderaa requested changes Jun 28, 2024
View reviewed changes
Copy link
Collaborator

@jvanderaa jvanderaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide documentation links on where I can find if these are valid or not.

@bryanculver bryanculver added the type: housekeeping Changes to the application which do not directly impact the end user label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvanderaa jvanderaa jvanderaa requested changes

@chadell chadell Awaiting requested review from chadell chadell will be requested when the pull request is marked ready for review chadell is a code owner

@glennmatthews glennmatthews Awaiting requested review from glennmatthews glennmatthews will be requested when the pull request is marked ready for review glennmatthews is a code owner

@pke11y pke11y Awaiting requested review from pke11y pke11y will be requested when the pull request is marked ready for review pke11y is a code owner

@scetron scetron Awaiting requested review from scetron scetron will be requested when the pull request is marked ready for review scetron is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
type: housekeeping Changes to the application which do not directly impact the end user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@snaselj @jvanderaa @chadell @bryanculver