Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added static group association model #453

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

tsm1th
Copy link
Contributor

@tsm1th tsm1th commented Nov 24, 2024

Closes #380

@tsm1th
Copy link
Contributor Author

tsm1th commented Nov 25, 2024

It was a false positive. Using the dynamic group name will not work correctly until the PR for that module is accepted and merged. Converted to ids instead.

@joewesch
Copy link
Contributor

It was a false positive. Using the dynamic group name will not work correctly until the PR for that module is accepted and merged. Converted to ids instead.

Hmm, I'd like to use name in the test if possible to verify it works. My guess is it won't take the full other module, just the QUERY_TYPES and ALLOWED_QUERY_PARAMS entries in the utils.

@tsm1th
Copy link
Contributor Author

tsm1th commented Nov 25, 2024

Yeah, just duplicate efforts. I'll fix the test to use names, but I'll wait till I can merge in the dynamic group changes. I'm going to bump the pynautobot version to fix the CI on that PR shortly.

@joewesch joewesch merged commit 0eccc50 into develop Dec 16, 2024
27 checks passed
@tsm1th tsm1th deleted the u/tsm1th-add-static-group-association branch December 16, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Model: StaticGroupAssociation
2 participants