create controller_managed_device_groups #432
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pugnacity
requested review from
jvanderaa,
jmcgill298 and
joewesch
as code owners
joewesch
reviewed
Oct 2, 2024
tests/integration/targets/latest/tasks/controller_managed_device_groups.yml
Outdated
Show resolved
Hide resolved
| that: | ||
| - test_two['changed'] | ||
| - test_two['controller_managed_device_group']['name'] == "Test Controller Group One" | ||
|
|
There was a problem hiding this comment.
For the integration tests, we try and stick to a pattern like this:
- Create with minimal required fields
- Try and create again to verify idempotency
- Create a second object with all fields
- Try and create again to verify idempotency
- Update one of the previous objects
- Try and update again to verify idempotency
- Delete one of the previous objects
- Try and delete again to verify idempotency
Please refactor your tests to follow this pattern.
tests/integration/targets/latest/tasks/controller_managed_device_groups.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
pugnacity
commented
Oct 4, 2024
pugnacity
commented
Oct 15, 2024
tests/integration/targets/latest/tasks/controller_managed_device_group.yml
Outdated
Show resolved
Hide resolved
joewesch
reviewed
Nov 20, 2024
| url: "{{ nautobot_url }}" | ||
| token: "{{ nautobot_token }}" | ||
| name: Test Controller Group One | ||
| weight: 2000 |
There was a problem hiding this comment.
Can you please add an assertion to validate that this field did indeed change?
| - test_three['changed'] | ||
| - test_three['controller_managed_device_group']['name'] == "Test Controller Group One" | ||
| - test_three['msg'] == "controller_managed_device_group Test Controller Group One updated" | ||
|
|
There was a problem hiding this comment.
Please add a duplicate update test to verify idempotency
joewesch
reviewed
Nov 20, 2024
joewesch
reviewed
Dec 2, 2024
|
Hello @pugnacity, just checking in with this PR. Do you require any assistance or have you just not been able to dedicate any time to it lately? |
|
Hello @joewesch it's a combination of no time and problems to get the tests to work...locally it seems to work. but the pipeline doesn't like it. |
joewesch
reviewed
Jan 8, 2025
tests/integration/targets/latest/tasks/controller_managed_device_group.yml
Outdated
Show resolved
Hide resolved
| - test_six['controller_managed_device_group'] == None | ||
| - test_six['msg'] == "controller_managed_device_group Test Controller Group Two already absent" | ||
|
|
||
| when: |
There was a problem hiding this comment.
This block and when should no longer be needed as we do it in main.yml now.
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
…ce_group.yml Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #423