Adds controller module. #408
Conversation
|
For future, I don't think you really need to include updates to the docs for every PR as it adds a lot of static to the changes. I think we should only do that during release PRs. |
|
Fixes #326 |
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
| - debug: | ||
| msg: "{{ nautobot_version }}" | ||
|
|
There was a problem hiding this comment.
| - debug: | |
| msg: "{{ nautobot_version }}" |
There was a problem hiding this comment.
I think it is alright to leave the debug message in here to print out for CI.
There was a problem hiding this comment.
I don't want to start a copy/pasta pattern for future modules. Can you add it to the main.yml instead and update the message to something more human readable?
There was a problem hiding this comment.
If you want, we could also move all of the existing conditional blocks out of the individual test files and into main.yml. It would then make sense to have a debug message there like "Running 2.2+ tests" and "Skipping 2.2+ tests because version is {{nautobot_version}}".
There was a problem hiding this comment.
I am approving this PR for now, but I'll want to come back and revisit this later if we need to continue to need to have tests conditionally run based on the version.
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
Co-authored-by: Joe Wesch <10467633+joewesch@users.noreply.github.com>
…ew_model_controllers
Adds new model for controllers.