Adds new relationship_association module #146
Conversation
joewesch
requested review from
FragmentedPacket,
jvanderaa and
jmcgill298
as code owners
|
@jvanderaa I have fixed all failing tests. |
| token: thisIsMyToken | ||
| relationship: 01234567-abcd-0123-abcd-012345678901 | ||
| source_type: dcim.device | ||
| source_id: abcdefgh-0123-abcd-0123-abcdefghijkl |
There was a problem hiding this comment.
What we could potentially do to make it easier for the user is to find the ID for them by taking the source.type and kwargs under source and find it for them, but it is extra logic I don't know if we have currently.
There was a problem hiding this comment.
The source/destination ID is not the ID of the type, but rather the actual Device/IP Address/etc. object to relate to the other.
There was a problem hiding this comment.
Correct. Here is an example:
- name: Create relationship association
networktocode.nautobot.relationship_association:
url: http://nautobot.local
token: thisIsMyToken
relationship: 01234567-abcd-0123-abcd-012345678901
source_type: dcim.device
source:
name: den-edge-01
site: DEN
destination_type: ipam.vrf
destination_id: 01234567-abcd-0123-abcd-123456789012
We can split on the source_type that will provide us the correct app and endpoint to query against.
We would then search for that for them rather than them having to lookup the ID by using the lookup plugin.
There was a problem hiding this comment.
Ah, yes. There are many places convenience logic like that could be added for sure.
Closes: #143