Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix caches db instance to 1 #158

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

fix caches db instance to 1 #158

wants to merge 3 commits into from

Conversation

jeffkala
Copy link

fix caches db instance to 1 which is the proper default as 0 is used for celery broker

glennmatthews
glennmatthews reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be more appropriate to remove the CACHES and CACHEOPS_REDIS settings from these altogether, as CACHES is simply recapitulating the defaults from nautobot.core.settings, and CACHEOPS_REDIS is no longer used in Nautobot.

glennmatthews
glennmatthews previously approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a step in the right direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnider2195 gsnider2195 gsnider2195 approved these changes

@glennmatthews glennmatthews glennmatthews left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffkala @glennmatthews @gsnider2195