Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CODEOWNERS #239

Conversation

josecelano
Copy link
Member

  • Fix the team name.
  • Define responsible maintainers for reviewing workflow changes.

@josecelano josecelano linked an issue Jun 3, 2022 that may be closed by this pull request
@josecelano josecelano requested a review from da2ce7 June 3, 2022 13:53
@da2ce7
Copy link
Contributor

da2ce7 commented Jun 3, 2022 via email

@josecelano
Copy link
Member Author

Hello José, With the Codeowners file, who and where is it defined the restrictions of editing the codeowners file itself?

Am 3/6/2022 um 15:53 schrieb Jose Celano @.***>:  @josecelano requested your review on: #239 Fix CODEOWNERS. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.

I do not know.

The documentation says:

People with admin or owner permissions can set up a CODEOWNERS file in a repository.

But you can have a different CODEOWNERS file on each branch. I suppose it's a kind of hardcoded protection rule for all branches. If you want to try I've created this test repo: https://github.com/josecelano-test/codeowners-test and added you as maintainer.

@josecelano josecelano force-pushed the issue-237-change-codeowners branch from f3e02fc to 862db19 Compare June 6, 2022 11:59
- Fix the team name.
- Define responsible maintainers for reviewing workflow changes.
@josecelano josecelano force-pushed the issue-237-change-codeowners branch from 862db19 to 1ba74b4 Compare June 6, 2022 12:23
@josecelano josecelano merged commit a190d4d into nautilus-cyberneering:main Jun 6, 2022
@josecelano josecelano deleted the issue-237-change-codeowners branch June 6, 2022 12:26
@josecelano
Copy link
Member Author

I've merged it in order to update the team name, but we have to find out what happens if a person with "write" permissions (not being ADMIN or repo OWNER) tries to update the file.

@josecelano
Copy link
Member Author

hi @da2ce7 , @yeraydavidrodriguez was able to push changes directly. So basically I suppose it only works for PRs. If you have "write" permission, you can change it. I suppose it's only a kind of warning to include some reviewers before merging PRs. That's all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change CODEOWNERS configuration
3 participants