feat: [#38] Extract new ID generation to a separate method

nautilus-cyberneering · May 4, 2022 · bcb2575 · bcb2575
1 parent e21b0d7
commit bcb2575
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 11 deletions.
diff --git a/__tests__/unit/commit-subject.test.ts b/__tests__/unit/commit-subject.test.ts
@@ -32,7 +32,7 @@ describe('CommitSubject', () => {
     )
 
     const commit3 = CommitSubjectParser.parseText(
-      '📝🈺: otherqueue: not queue job.id.1 commit-no prefix'
+      '📝🈺: other-queue: not queue job.id.1 commit-no prefix'
     )
     expect(commit3.belongsToQueue(new QueueName('standard commit'))).toBe(false)
   })

diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/queue.ts b/src/queue.ts
@@ -182,17 +182,21 @@ export class Queue {
 
   // Job states: new -> started -> finished
 
-  async createJob(payload: string): Promise<Job> {
+  getNextJobId(): number {
     const latestMessage = this.getLatestMessage()
     this.guardThatLastMessageWasJobFinishedOrNull(latestMessage)
 
-    const newJobId = latestMessage.isNull() ? 0 : latestMessage.jobId() + 1
+    return latestMessage.isNull() ? 0 : latestMessage.jobId() + 1
+  }
+
+  async createJob(payload: string): Promise<Job> {
+    const nextJobId = this.getNextJobId()
 
-    const message = new NewJobMessage(payload, newJobId)
+    const message = new NewJobMessage(payload, nextJobId)
 
     const commit = await this.commitMessage(message)
 
-    return new Job(payload, commit.hash, newJobId)
+    return new Job(payload, commit.hash, nextJobId)
   }
 
   async markJobAsStarted(payload: string): Promise<CommitInfo> {