Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine private WebSocket messages processing for Bybit #2170

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Refine private WebSocket messages processing for Bybit #2170

merged 1 commit into from
Jan 3, 2025

Conversation

sunlei
Copy link
Collaborator

@sunlei sunlei commented Jan 3, 2025

Pull Request

Refine private WebSocket messages processing for Bybit.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 3, 2025

CodSpeed Performance Report

Merging #2170 will degrade performances by 44.44%

Comparing sunlei/bybit-refine-ws-msg (8bd8274) with develop (4b2ce68)

Summary

❌ 1 regressions
✅ 52 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop sunlei/bybit-refine-ws-msg Change
❌ test_condition_none 12.3 µs 22.1 µs -44.44%

@cjdsellers cjdsellers merged commit 8750ce9 into develop Jan 3, 2025
17 checks passed
@cjdsellers cjdsellers deleted the sunlei/bybit-refine-ws-msg branch January 3, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunlei @cjdsellers