Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request_aggregated_bars #2137

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Dec 23, 2024

Pull Request

Bug fix, params was used instead of metadata for "bars_market_data_type"

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #2137 will improve performances by 68.71%

Comparing faysou:aggregatedbars-fix (5a66ae6) with develop (80b2317)

Summary

⚡ 1 improvements
✅ 51 untouched benchmarks

Benchmarks breakdown

Benchmark develop faysou:aggregatedbars-fix Change
test_condition_none 22.1 µs 13.1 µs +68.71%

@cjdsellers cjdsellers merged commit 78ca70f into nautechsystems:develop Dec 23, 2024
11 checks passed
@faysou faysou deleted the aggregatedbars-fix branch January 7, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants