Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default http_base_url for Bybit #2110

Merged

Conversation

sunlei
Copy link
Collaborator

@sunlei sunlei commented Dec 14, 2024

Pull Request

Change default http_base_url for Bybit.

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

codspeed-hq bot commented Dec 14, 2024

CodSpeed Performance Report

Merging #2110 will degrade performances by 44.39%

Comparing sunlei:sunlei/bybit-default-http-base (358d642) with develop (b1e06cc)

Summary

❌ 1 regressions
✅ 51 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark develop sunlei:sunlei/bybit-default-http-base Change
test_symbol_equality 13.8 µs 24.8 µs -44.39%

@cjdsellers cjdsellers merged commit 18ca0b4 into nautechsystems:develop Dec 14, 2024
11 checks passed
@sunlei sunlei deleted the sunlei/bybit-default-http-base branch December 15, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants