Refine BybitEnumParser for Bybit
#2107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2107 will not alter performanceComparing Summary
|
cjdsellers
approved these changes
Dec 14, 2024
| @@ -537,50 +554,27 @@ def parse_bybit_order_type( | |||
| def parse_nautilus_time_in_force(self, time_in_force: TimeInForce) -> BybitTimeInForce: | |||
| try: | |||
| return self.nautilus_to_bybit_time_in_force[time_in_force] | |||
| except KeyError: | |||
| except KeyError as exec: | |||
There was a problem hiding this comment.
To align with Rust, we standardized on using as e for the exception variable name. (I'll refactor this after merging.)
| @@ -145,3 +147,62 @@ def test_parse_nautilus_order_side( | |||
| # ) -> None: | |||
| # result = self._enum_parser.parse_nautilus_order_status(order_status) | |||
| # assert result == bybit_order_status | |||
|
|
|||
| @pytest.mark.parametrize( | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Refine
BybitEnumParserfor Bybit.Type of change
How has this change been tested?
Tests added.