Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bybit WebSocket private channel reconnect #2097

Merged

Conversation

sunlei
Copy link
Collaborator

@sunlei sunlei commented Dec 10, 2024

Pull Request

During reconnection, the code creates two asynchronous tasks concurrently: authentication and _subscribe_all.
These two operations are executed in parallel.
This can result in the re-subscription request being sent before authentication is completed, leading to a Request not authorized error.

  • Bug fix (non-breaking change which fixes an issue)

Copy link

codspeed-hq bot commented Dec 10, 2024

CodSpeed Performance Report

Merging #2097 will not alter performance

Comparing sunlei:sunlei/fix-bybit-ws-reconnect (4ca04ea) with develop (aa1c3f8)

Summary

✅ 52 untouched benchmarks

@cjdsellers cjdsellers merged commit 7f917ef into nautechsystems:develop Dec 10, 2024
11 checks passed
@sunlei sunlei deleted the sunlei/fix-bybit-ws-reconnect branch December 12, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants