Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix order handling for BEST_EFFORT_CANCELED messages of dYdX #2095

Merged
merged 4 commits into from
Dec 9, 2024

Conversation

davidsblom
Copy link
Member

Pull Request

Fix order handling for BEST_EFFORT_CANCELED messages of dYdX

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How has this change been tested?

Live example and unit tests

Copy link

codspeed-hq bot commented Dec 9, 2024

CodSpeed Performance Report

Merging #2095 will not alter performance

Comparing dydx-best-effort-canceled (27c28d5) with develop (9880b51)

Summary

✅ 52 untouched benchmarks

@davidsblom davidsblom marked this pull request as draft December 9, 2024 11:10
@davidsblom davidsblom marked this pull request as ready for review December 9, 2024 14:58
@davidsblom davidsblom requested a review from cjdsellers December 9, 2024 14:58
@cjdsellers cjdsellers merged commit 2a3a1b8 into develop Dec 9, 2024
11 checks passed
@cjdsellers cjdsellers deleted the dydx-best-effort-canceled branch December 9, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants