Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific params for data subscriptions and requests #2083

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

faysou
Copy link
Collaborator

@faysou faysou commented Nov 30, 2024

Pull Request

Add ability to request and subscribe to databento bbo-1m and bbo-1s quotes

Also refactor of request, subscribe and unsubscribe functions to include metadata information containing a params dictionary for extra parameters in the implementation of some client methods

Type of change

  • New feature (non-breaking change which adds functionality)

How has this change been tested?

Added notebook example for requests. Not tested for subscribe, although here it uses a function that already is used for various schemas.

@faysou faysou marked this pull request as ready for review November 30, 2024 18:49
@faysou faysou force-pushed the request-bbo branch 3 times, most recently from dd21f78 to 861e188 Compare November 30, 2024 21:39
Copy link

codspeed-hq bot commented Nov 30, 2024

CodSpeed Performance Report

Merging #2083 will not alter performance

Comparing faysou:request-bbo (5625aba) with develop (02571f4)

Summary

✅ 52 untouched benchmarks

@faysou faysou force-pushed the request-bbo branch 4 times, most recently from 6799d59 to 8d06834 Compare December 3, 2024 11:07
@faysou faysou changed the title Add ability to request databento bbo-1m and bbo-1s quotes Add ability to request and subscribe to databento bbo-1m and bbo-1s quotes Dec 3, 2024
@cjdsellers cjdsellers changed the title Add ability to request and subscribe to databento bbo-1m and bbo-1s quotes Add specific params for data subscriptions and requests Dec 4, 2024
@cjdsellers cjdsellers merged commit 43c342e into nautechsystems:develop Dec 4, 2024
11 checks passed
@faysou faysou deleted the request-bbo branch December 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants