Add docs and fix rate limiting for websockets of dYdX #1999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjdsellers
approved these changes
Oct 12, 2024
| Returns | ||
| ------- | ||
| bool | ||
| Whether the client is already subscribed to this topic. |
There was a problem hiding this comment.
I think it's best to add only additional info relative to the return type for the description, in this case it's been covered in the main description already.
There was a problem hiding this comment.
Makes sense. Thanks!
| ---------- | ||
| raw : bytes | ||
| The received message in bytes. | ||
| """ |
There was a problem hiding this comment.
Small point, but we tend to leave a single blank line at the end of the docstring. The docformatter lint may just handle this when its turned back on.
There was a problem hiding this comment.
Thanks for formatting the code already.
|
Thanks @davidsblom 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Add docs and fix rate limiting for websockets of dYdX
Type of change
Delete options that are not relevant.
How has this change been tested?
Live example