Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs update #1991

Merged
merged 9 commits into from
Oct 9, 2024
Merged

Docs update #1991

merged 9 commits into from
Oct 9, 2024

Conversation

FarukhS52
Copy link
Contributor

Pull Request

Include a summary of the changes.

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this change been tested?

Describe how this code was/is tested.

@CLAassistant
Copy link

CLAassistant commented Oct 9, 2024

CLA assistant check
All committers have signed the CLA.

@cjdsellers cjdsellers changed the title Docs Update Docs update Oct 9, 2024
Copy link
Member

@cjdsellers cjdsellers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good updates, just a couple of minor comments below.

README.md Outdated Show resolved Hide resolved
@@ -55,7 +55,7 @@ When starting the trading node, you'll receive immediate confirmation of whether
credentials are valid and have trading permissions.

:::tip
Best practice is to manage your credentials using environment variables.
The best practice is to manage your credentials using environment variables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably more concise to keep the original.

docs/integrations/bybit.md Outdated Show resolved Hide resolved
docs/integrations/polymarket.md Outdated Show resolved Hide resolved
@FarukhS52
Copy link
Contributor Author

@cjdsellers Thanks for the feedback. I have made the changes, thank you .

@cjdsellers cjdsellers merged commit 5eb47ad into nautechsystems:develop Oct 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants