polish argument passing, add e2e test

README.md

@@ -31,11 +31,12 @@ The decisions you make are stored in `audit-resolve.json` to keep track of it in
 ### Arguments 
 
 ```
---ignoreLow automatically resolve issue to ignored if severity of all vulnerabilities in that dependency is low
 --yarn switched to yarn package manager as the command to support
 --migrate forces migration to a new file and format even if no modifications are made to decisions
 ```
 
+All other arguments are passed down to the npm/yarn audit call
+
 ### Running in CI
 
 One of the problems this solves is running audit as part of your build pipeline.
@@ -53,6 +54,8 @@ For JSON output (similar to `npm audit --json`), run
 check-audit --json
 ```
 
+All other arguments are passed down to the npm/yarn audit call
+
 ## Features
 
 Want to give it a go? Download this repo and run `npm run testdrive`

package.json

@@ -43,5 +43,7 @@
     "yargs-parser": "^13.1.1",
     "yargs-unparser": "^1.5.0"
   },
-  "devDependencies": {}
+  "devDependencies": {
+    "pre-commit": "^1.2.2"
+  }
 }

src/pkgmanagers/npm.js

@@ -1,4 +1,5 @@
-const unparse = require('../unparse');
+const unparse = require('../unparse')
+const skipArgs = require('../skipArgs')
 
 function getCommand(action) {
     // Derived from npm-audit-report
@@ -14,7 +15,7 @@ function getCommand(action) {
 module.exports = {
     version: 1,
     getAudit({ promiseCommand, argv, shellOptions }) {
-        const unparsed = unparse(argv, ['json']);
+        const unparsed = unparse(argv, skipArgs)
 
         return promiseCommand(`npm audit --json ${unparsed}`, shellOptions)
             .then(output => {

src/pkgmanagers/yarn.js

@@ -1,5 +1,8 @@
 const packageJSON = require(require('path').resolve('./package.json'))
 const jsonlines = require('jsonlines')
+const unparse = require('../unparse')
+const skipArgs = require('../skipArgs')
+
 
 function aggregateActions(audit, entry) {
     const modulename = entry.data.advisory.module_name
@@ -33,7 +36,7 @@ module.exports = {
     version: 1,
     getAudit({ promiseCommand, argv, shellOptions }) {
         console.error('WARNING: yarn support is experimental')
-        const unparsed = unparse(argv, ['json']);
+        const unparsed = unparse(argv, skipArgs)
 
         return promiseCommand(`yarn audit --json ${unparsed}`, shellOptions)
             .then(output => {

src/skipArgs.js

@@ -0,0 +1 @@
+module.exports = ['json', 'migrate', 'yarn', 'mock', 'fix']

test/e2e/test.sh

@@ -87,4 +87,22 @@ if [ $EXITCODE -ne 0 ]; then
   exit 1
 fi
 
+
+echo 'runs check on npm with extra args'
+RESULT1=`node check.js --production --XbookmarkX --migrate | grep XbookmarkX | wc -l`  
+RESULT2=`node check.js --production --XbookmarkX --migrate | grep XbookmarkX | grep migrate | wc -l` 
+
+if [ $RESULT1 -ne 1 ] || [ $RESULT2 -ne 0 ]; then
+  echo "FAILED, expected passing arguments down to work, expected filtering out arguments to work"
+  exit 1
+fi
+
+echo 'runs check on yarn with extra args'
+RESULT1=`node check.js --yarn --production --XbookmarkX --migrate | grep XbookmarkX | wc -l`  
+RESULT2=`node check.js --yarn --production --XbookmarkX --migrate | grep XbookmarkX | grep migrate | wc -l` 
+
+if [ $RESULT1 -ne 1 ] || [ $RESULT2 -ne 0 ]; then
+  echo "FAILED, expected passing arguments down to work, expected filtering out arguments to work"
+  exit 1
+fi
 echo '- Runs ----------------------- OK'