Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new editor theme named darkvision #3325

Merged
merged 4 commits into from
Feb 25, 2024

Conversation

RKuerten
Copy link
Collaborator

This is a new dark theme for the editor. I called it darkvision, but it is quite colorful.

I created this one because I felt the others didn't have colors for all things and mainly the colors for the term :: definition thing has really bad colors on dark themes

Brew Editor
image

Theme Editor
image

@5e-Cleric
Copy link
Member

I recommend an addition:

    .define:not(.term):not(.definition) {
        background:#333;
    }

@5e-Cleric
Copy link
Member

5e-Cleric commented Feb 24, 2024

cm-error by itself (like a bad selector) has no styling, should fix that.

you can easily check it by making nested css, which works but codemirror 5 does not show as correct.

your code could benefit from css nesting too:

.cm-s-default .cm-link {
    color: #dd6300;
}
/* links */
.cm-s-default .cm-string {
    color: #aa8261;
}

is equal to

.cm-s-default {
    .cm-link {
        color: #dd6300;
    }
    /* links */
    .cm-string {
        color: #aa8261;
    }
}

Other than that, your theme is great!

@5e-Cleric 5e-Cleric added this to the V3.12 milestone Feb 24, 2024
@RKuerten
Copy link
Collaborator Author

Finished cleaning up, let me know if there is something else you think it needs to be changed @5e-Cleric

@5e-Cleric 5e-Cleric merged commit a608df9 into naturalcrit:master Feb 25, 2024
2 checks passed
@5e-Cleric
Copy link
Member

Thanks @RKuerten !

@RKuerten RKuerten deleted the new-theme branch February 25, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants