Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEW THEME]: Unearthed Arcana #3022

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

G-Ambatte
Copy link
Collaborator

This PR adds a new theme: Unearthed Arcana. It mimics the very basic styling of those documents, with monochrome text and no visible background texture.

@5e-Cleric
Copy link
Member

Adding a reference picture, just in case:
image

Copy link
Collaborator

@Gazook89 Gazook89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not familiar with the unearthed arcana style; shouldn't this theme also include the PHB snippets? It doesn't have class tables, stat blocks, etc.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know the current early convention for the dropdownTextures is to use a screencap of a blank portion of the page...hence dropdownTextures as the file name.

But here, I'm wondering if this one theme might be an exception? It currently matches the Base theme texture...just blank white. I don't know if this theme can be distinguished in any way in the texture? If not, just leave it white.

@G-Ambatte
Copy link
Collaborator Author

G-Ambatte commented Oct 4, 2023

I am not familiar with the unearthed arcana style; shouldn't this theme also include the PHB snippets? It doesn't have class tables, stat blocks, etc.

I was about to say "UA never includes full classes, only sub-classes at most"... But then I remembered that the 6E/5.5E/OneDnD/D&DNext™/whatever it's called today playtest materials use the Unearthed Arcana styling, and include full class tables.

See here:
image
from https://media.dndbeyond.com/compendium-images/ua/ph-playtest6/OJVW7QLuHjEFCCVs/UA-2023-PH-Playtest6.pdf, page 2

So it's the long way of saying: yes, agreed, it probably should include those snippets.

@5e-Cleric 5e-Cleric mentioned this pull request Jan 10, 2024
@5e-Cleric 5e-Cleric changed the title Add new theme - Unearthed Arcana [NEW THEME]: Unearthed Arcana Jan 16, 2024
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3022 January 17, 2024 17:22 Inactive
@calculuschild calculuschild temporarily deployed to homebrewery-pr-3022 January 18, 2024 20:04 Inactive
@Gazook89
Copy link
Collaborator

Someone on discord asked about a UA theme. I found this existing brew that may be of help to flesh this PR out a bit: https://homebrewery.naturalcrit.com/share/kFDWFxP4Gglk

@dbolack-ab
Copy link
Collaborator

Would it be desirable to use this as a test case for the "naturacrit user" user themes?

@calculuschild
Copy link
Member

I think so. 👍

@5e-Cleric
Copy link
Member

I think so. 👍

question, how are we going to account for which snippets this theme will have access to?

@dbolack-ab
Copy link
Collaborator

I think so. 👍

question, how are we going to account for which snippets this theme will have access to?

Snippets should be inherited. If they aren't, then it needs to be solved one of the ways we discussed user snippets.

@5e-Cleric
Copy link
Member

I think so. 👍

question, how are we going to account for which snippets this theme will have access to?

Snippets should be inherited. If they aren't, then it needs to be solved one of the ways we discussed user snippets.

Snippets will be inherited, but themes may have their own snippets, we'll have to implement the snippets in brew as we discussed.

@G-Ambatte
Copy link
Collaborator Author

G-Ambatte commented Jul 22, 2024

I very quickly created the following test document in the test deployment: https://homebrewery-pr-3022.herokuapp.com/share/HQIUEb0vYNnF

Because it uses the new theme in this PR, it will not work on the production Homebrewery website.

Snippets still to be resolved at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

5 participants