Add more tests for POST /api route #1206
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not review f67a8a1 in this PR, because it is basically #1183 squashed into a single commit - I can't add more tests without having an infrastructure for them first. So, if you have any comments about that part, please submit them into #1183 instead.
To review added test cases just take a look at b6cd9e8
While working on this PR I've submitted #1203, #1204 and #1205 - not all of them are high-severity issues, but still there are room for improvement.
P.S. code formatting is a mess: I tried to launch linter, but it only made it worse: I will apply proper formatting in subsequent commits