Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme: Themes can select themselves as Theme Source #3614

Closed
G-Ambatte opened this issue Aug 3, 2024 · 4 comments · Fixed by #3615
Closed

Theme: Themes can select themselves as Theme Source #3614

G-Ambatte opened this issue Aug 3, 2024 · 4 comments · Fixed by #3615

Comments

@G-Ambatte
Copy link
Collaborator

Your idea:

As shown in the below image, it is possible for a brew tagged with meta:theme to select itself from the dropdown list. This seems incorrect.

image
@dbolack-ab
Copy link
Collaborator

That's a regression. I remember explicitly working that exact problem. :/

@G-Ambatte
Copy link
Collaborator Author

G-Ambatte commented Aug 3, 2024 •
edited
Loading

This seems to fix it:

image

@calculuschild
Copy link
Member

I probably broke it with my revisions.

@G-Ambatte G-Ambatte mentioned this issue Aug 3, 2024
Merged
G-Ambatte added a commit to G-Ambatte/homebrewery that referenced this issue Aug 3, 2024
@G-Ambatte
Merge branch 'master' into fixSelectSelfInThemeSource-naturalcrit#3614
8ef319d
@G-Ambatte
Copy link
Collaborator Author

I've just created PR #3615 with a quick fix, now that I've identified one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Prevent self-selection of User Theme G-Ambatte/homebrewery
3 participants
@calculuschild @G-Ambatte @dbolack-ab