Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SERVER] Fix Admin pages #2657

Closed
4 tasks done
G-Ambatte opened this issue Feb 2, 2023 · 0 comments · Fixed by #2658
Closed
4 tasks done

[SERVER] Fix Admin pages #2657

G-Ambatte opened this issue Feb 2, 2023 · 0 comments · Fixed by #2658
Assignees
@G-Ambatte
Labels
P2 - minor feature or not urgent Minor bugs or less-popular features

Comments

@G-Ambatte
Copy link
Collaborator

G-Ambatte commented Feb 2, 2023 •
edited
Loading

Your idea:

The Heroku deployment process automatically runs the NPM build script during the deployment. This step erases the contents of the /build folder, which deletes the output of the postinstall script. The build script also does not build the /admin pages, which postinstall does.

  • Remove the obsolete postinstall script.
    • Delete line 31 of package.json.
    • Removal of postinstall consistently causes test failures; leave intact
  • Alter the build script to include the /admin pages.
    • Change line 15 of package.json to node scripts/buildHomebrew.js && node scripts/buildAdmin.js
  • Remove the now obsolete buildall script.
    • Delete line 16 of package.json.
  • Add to change.log for v3.7.0
@G-Ambatte G-Ambatte self-assigned this Feb 2, 2023
@G-Ambatte G-Ambatte added the P2 - minor feature or not urgent Minor bugs or less-popular features label Feb 2, 2023
@G-Ambatte G-Ambatte added this to the v3.7.0 milestone Feb 2, 2023
@G-Ambatte G-Ambatte mentioned this issue Feb 2, 2023
Merged
G-Ambatte added a commit to G-Ambatte/homebrewery that referenced this issue Feb 2, 2023
@G-Ambatte
Merge branch 'master' into fixAdminPages-naturalcrit#2657
e5996db
G-Ambatte added a commit to G-Ambatte/homebrewery that referenced this issue Feb 6, 2023
@G-Ambatte
Merge branch 'master' into fixAdminPages-naturalcrit#2657
dae9794
@G-Ambatte G-Ambatte mentioned this issue Feb 14, 2023
Open
6 tasks
G-Ambatte added a commit to G-Ambatte/homebrewery that referenced this issue Mar 12, 2023
@G-Ambatte
Merge branch 'master' into fixAdminPages-naturalcrit#2657
22e275a
calculuschild added a commit that referenced this issue Mar 23, 2023
@calculuschild
Merge pull request #2658 from G-Ambatte/fixAdminPages-#2657
5d77dea 
Fix admin pages #2657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-Ambatte G-Ambatte

Labels
P2 - minor feature or not urgent Minor bugs or less-popular features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix admin pages #2657 G-Ambatte/homebrewery
1 participant
@G-Ambatte