Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML Enginering: quote go-version string #53

Merged
merged 1 commit into from
May 8, 2023
Merged

Conversation

philpennock
Copy link
Member

Try to ensure that when we switch to Go 1.20 we don't forget to quote the string to protect against the version being parsed as 1.2.

Try to ensure that when we switch to Go 1.20 we don't forget to quote the
string to protect against the version being parsed as `1.2`.
@philpennock philpennock requested review from aricart and wallyqs May 7, 2023 05:33
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4905558872

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.429%

Totals Coverage Status
Change from base Build 4480150340: 0.0%
Covered Lines: 417
Relevant Lines: 525

💛 - Coveralls

@philpennock philpennock merged commit 64eab80 into main May 8, 2023
@philpennock philpennock deleted the pdp/yaml-engineering branch May 8, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants