Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unify KeyPair and Curve interfaces #41

Merged
merged 1 commit into from
Dec 15, 2022
Merged

unify KeyPair and Curve interfaces #41

merged 1 commit into from
Dec 15, 2022

Conversation

aricart
Copy link
Member

@aricart aricart commented Dec 14, 2022

[FIX] unified the nkey and curve key interfaces
[FIX] made CreatePairWithRand delegate to CreateCurveKeysWithRand for curve prefixes [FIX] made FromSeed delegate to FromCurveSeed for curve prefixes

@coveralls
Copy link

coveralls commented Dec 14, 2022

Pull Request Test Coverage Report for Build 192

  • 35 of 40 (87.5%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 79.429%

Changes Missing Coverage Covered Lines Changed/Added Lines %
nkeys.go 2 4 50.0%
public.go 12 15 80.0%
Totals Coverage Status
Change from base Build 176: 0.5%
Covered Lines: 417
Relevant Lines: 525

💛 - Coveralls

public.go Outdated Show resolved Hide resolved
errors.go Show resolved Hide resolved
[FIX] made CreatePairWithRand delegate to CreateCurveKeysWithRand for curve prefixes
[FIX] made FromSeed delegate to FromCurveSeed for curve prefixes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekcollison derekcollison merged commit 47c7408 into main Dec 15, 2022
@aricart aricart deleted the curve2 branch December 15, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants