Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies #35

Merged
merged 1 commit into from
Nov 30, 2022
Merged

Update dependencies #35

merged 1 commit into from
Nov 30, 2022

Conversation

rodrigc
Copy link
Contributor

@rodrigc rodrigc commented Sep 19, 2022 •
edited
Loading

@wallyqs wallyqs requested a review from philpennock September 19, 2022 17:09
kozlovic
kozlovic approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Always good to update to latest from time to time, but the initial report does not affect the library, first because it was already at a revision that was past the affected one, and also that we are not using ssh server in this library.

@kozlovic
Copy link
Member

Will let @philpennock comment, but I think we could merge this PR. Thanks!

@derekcollison derekcollison merged commit b8568d8 into nats-io:master Nov 30, 2022
@rodrigc rodrigc deleted the update-crypto branch November 30, 2022 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kozlovic kozlovic kozlovic approved these changes

@philpennock philpennock Awaiting requested review from philpennock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodrigc @kozlovic @derekcollison