Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exported NKeys Error Enhancement #32

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Exported NKeys Error Enhancement #32

merged 1 commit into from
Feb 14, 2022

Conversation

nanjj
Copy link
Contributor

@nanjj nanjj commented Feb 11, 2022

Make the errors exported outside const instead variable, so that the
users can not change them, and do cleanup to the others return errors
not defined clearly.

Signed-off-by: JUN JIE NAN nanjunjie@gmail.com

Make the errors exported outside const instead variable, so that the
users can not change them, and do cleanup to the others return errors
not defined clearly.

Signed-off-by: JUN JIE NAN <nanjunjie@gmail.com>
@coveralls
Copy link

coveralls commented Feb 11, 2022

Pull Request Test Coverage Report for Build 137

  • 4 of 6 (66.67%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.818%

Changes Missing Coverage Covered Lines Changed/Added Lines %
creds_utils.go 1 3 33.33%
Totals Coverage Status
Change from base Build 135: 0.1%
Covered Lines: 306
Relevant Lines: 374

💛 - Coveralls

Copy link
Member

@kozlovic kozlovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contribution.

errors.go Show resolved Hide resolved
@aricart
Copy link
Member

aricart commented Feb 14, 2022

LGTM

@kozlovic kozlovic merged commit adbe4f7 into nats-io:master Feb 14, 2022
aricart added a commit that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants