Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Invalid heartbeat timer for Consumer.Messages #1786

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

piotrpio
Copy link
Collaborator

This fixes an issue where for Consumer.Messages the heartbeat error would be returned after 4idle heartbeat (instead of 2)

Signed-off-by: Piotr Piotrowski piotr@synadia.com

This fixes an issue where for `Consumer.Messages` the heartbeat error would be returned after 4*idle heartbeat (instead of 2*)

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@piotrpio piotrpio requested a review from Jarema January 23, 2025 17:30
@coveralls
Copy link

Coverage Status

coverage: 84.943% (+0.01%) from 84.93%
when pulling 4b9e12d on fix-invalid-pull-heartbeat
into bb3ad1c on main.

Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piotrpio piotrpio merged commit f7dfee9 into main Jan 28, 2025
6 checks passed
@piotrpio piotrpio deleted the fix-invalid-pull-heartbeat branch January 28, 2025 14:08
@piotrpio piotrpio mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants