Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement prometheus.Gather interface #101

Merged
merged 1 commit into from
Aug 30, 2022
Merged

implement prometheus.Gather interface #101

merged 1 commit into from
Aug 30, 2022

Conversation

caleblloyd
Copy link
Contributor

Fixes #100

@caleblloyd caleblloyd marked this pull request as draft August 24, 2022 21:01
@caleblloyd caleblloyd force-pushed the prometheus-gatherer branch 2 times, most recently from ebc942b to b6dbab8 Compare August 25, 2022 15:30
@caleblloyd caleblloyd marked this pull request as ready for review August 29, 2022 13:51
implement prometheus.Gather interface
d7e2e0f 
Signed-off-by: Caleb Lloyd <caleb@synadia.com>
hooksie1
hooksie1 approved these changes Aug 29, 2022
View reviewed changes
Copy link
Contributor

@hooksie1 hooksie1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 456881e into main Aug 30, 2022
@wallyqs wallyqs deleted the prometheus-gatherer branch August 30, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hooksie1 hooksie1 hooksie1 approved these changes

@nsurfer nsurfer nsurfer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement prometheus.Gatherer interface for usage in libraries
4 participants
@caleblloyd @hooksie1 @nsurfer @wallyqs